henrib commented on code in PR #5060:
URL: https://github.com/apache/hive/pull/5060#discussion_r1480314107
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java:
##########
@@ -732,10 +756,25 @@ public static void startMetaStore(int port,
HadoopThriftAuthBridge bridge,
}
// optionally create and start the property server and servlet
propertyServer = PropertyServlet.startServer(conf);
+ // optionally create and start the Iceberg REST server and servlet
+ icebergServer = startIcebergCatalog(conf);
thriftServer.start();
}
+ static Server startIcebergCatalog(Configuration configuration) {
+ try {
+ Class<?> iceClazz =
Class.forName("org.apache.iceberg.rest.HMSCatalogServer");
+ Method iceStart = iceClazz.getMethod("startServer", Configuration.class);
+ return (Server) iceStart.invoke(null, configuration);
+ } catch (ClassNotFoundException xnf) {
+ return null;
+ } catch (NoSuchMethodException | IllegalAccessException |
InvocationTargetException e) {
+ LOG.error("error starting Iceberg REST server {}", e);
Review Comment:
Updated code accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
