deniskuzZ commented on code in PR #5047:
URL: https://github.com/apache/hive/pull/5047#discussion_r1483120123
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##########
@@ -234,7 +241,12 @@ public void
preCreateTable(org.apache.hadoop.hive.metastore.api.Table hmsTable)
// - InputFormatConfig.TABLE_SCHEMA, InputFormatConfig.PARTITION_SPEC
takes precedence so the user can override the
// Iceberg schema and specification generated by the code
- Schema schema = schema(catalogProperties, hmsTable);
+ Set<String> identifierFields =
Optional.ofNullable(request.getPrimaryKeys())
Review Comment:
why do we need Set here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
