deniskuzZ commented on code in PR #4943:
URL: https://github.com/apache/hive/pull/4943#discussion_r1484136221
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/HiveAggregateInsertDeleteIncrementalRewritingRule.java:
##########
@@ -116,7 +121,7 @@ protected IncrementalComputePlanWithDeletedRows
createJoinRightInput(RelOptRuleC
aggInput = HiveHepExtractRelNodeRule.execute(aggInput);
aggInput = new HiveRowIsDeletedPropagator(relBuilder).propagate(aggInput);
- int rowIsDeletedIdx = aggInput.getRowType().getFieldCount() - 1;
+ int rowIsDeletedIdx = aggInput.getRowType().getFieldCount() - 2;
Review Comment:
should we add some comment for this magic number `-2`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
