deniskuzZ commented on code in PR #5076: URL: https://github.com/apache/hive/pull/5076#discussion_r1500862337
########## ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java: ########## @@ -691,6 +693,18 @@ Map<Path, List<String>> removeScheme(Map<Path, List<String>> pathToAliases) { public RecordReader getRecordReader(InputSplit split, JobConf job, Reporter reporter) throws IOException { if (!(split instanceof CombineHiveInputSplit)) { + if (split instanceof FileSplit) { Review Comment: won't we break here legacy code? prev if !(split instanceof CombineHiveInputSplit), we fallback to HiveInputFormat#getRecordReader -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org