deniskuzZ commented on code in PR #4761: URL: https://github.com/apache/hive/pull/4761#discussion_r1508758046
########## iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestUtilCyclicBarrier.java: ########## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.mr.hive; + +import java.util.concurrent.CyclicBarrier; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class TestUtilCyclicBarrier { + private static final Logger LOG = LoggerFactory.getLogger(TestUtilCyclicBarrier.class); + private static TestUtilCyclicBarrier instance; + private final CyclicBarrier cyclicBarrier; + + private TestUtilCyclicBarrier(int parties) { + cyclicBarrier = new CyclicBarrier(parties); Review Comment: my bad, I think it would be better to use Phaser here, since we want dynamic number of parties https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/Phaser.html ```` final Phaser phaser = new Phaser(1); // "1" to register self // create and start threads for (final Runnable task : tasks) { phaser.register(); new Thread() { public void run() { phaser.arriveAndAwaitAdvance(); // await all creation task.run(); } }.start(); } // allow threads to start and deregister self phaser.arriveAndDeregister(); ```` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
