deniskuzZ commented on code in PR #5111:
URL: https://github.com/apache/hive/pull/5111#discussion_r1511029458
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/FilesForCommit.java:
##########
@@ -28,26 +28,37 @@
import org.apache.iceberg.DataFile;
import org.apache.iceberg.DeleteFile;
import org.apache.iceberg.relocated.com.google.common.base.MoreObjects;
+import org.apache.iceberg.util.CharSequenceSet;
public class FilesForCommit implements Serializable {
private final Collection<DataFile> dataFiles;
private final Collection<DeleteFile> deleteFiles;
private Collection<DataFile> referencedDataFiles;
+ private final CharSequenceSet referencedDataFilesInDeleteFiles;
+
public FilesForCommit(Collection<DataFile> dataFiles, Collection<DeleteFile>
deleteFiles) {
this(dataFiles, deleteFiles, Collections.emptyList());
}
public FilesForCommit(Collection<DataFile> dataFiles, Collection<DeleteFile>
deleteFiles,
- Collection<DataFile> referencedDataFiles) {
+ Collection<DataFile> referencedDataFiles, CharSequenceSet
referencedDataFilesInDeleteFiles) {
Review Comment:
could we please rename
````
referencedDataFiles -> replacedDataFiles;
referencedDataFilesInDeleteFiles -> referencedDataFiles;
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
