deniskuzZ commented on code in PR #5076:
URL: https://github.com/apache/hive/pull/5076#discussion_r1523047140


##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java:
##########
@@ -1720,6 +1723,41 @@ protected static MoveWork mergeMovePaths(Path 
condInputPath, MoveWork linkedMove
     return newWork;
   }
 
+  private static void 
setStorageHandlerAndPropertiesForMerge(ConditionalResolverMergeFilesCtx mrCtx, 
MoveWork work) {

Review Comment:
   could we follow single responsibility principle



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to