zhangbutao commented on code in PR #5063:
URL: https://github.com/apache/hive/pull/5063#discussion_r1524613898
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java:
##########
@@ -3199,19 +3199,24 @@ public Map<Map<String, String>, Partition>
loadDynamicPartitions(final LoadTable
partitionNames.add(Warehouse.makeDynamicPartNameNoTrailingSeperator(details.fullSpec));
}
}
- List<Partition> partitions = Hive.get().getPartitionsByNames(tbl,
partitionNames);
- for(Partition partition : partitions) {
- LOG.debug("HMS partition spec: {}", partition.getSpec());
- partitionDetailsMap.entrySet().parallelStream()
- .filter(entry ->
entry.getValue().fullSpec.equals(partition.getSpec()))
- .findAny().ifPresent(entry -> {
- entry.getValue().partition = partition;
- entry.getValue().hasOldPartition = true;
- });
- }
- // no need to fetch partition again in tasks since we have already
fetched partitions
- // info in getPartitionsByNames()
- fetchPartitionInfo = false;
+ try {
+ List<Partition> partitions = Hive.get().getPartitionsByNames(tbl,
partitionNames);
+ for(Partition partition : partitions) {
+ LOG.debug("HMS partition spec: {}", partition.getSpec());
+ partitionDetailsMap.entrySet().parallelStream()
+ .filter(entry ->
entry.getValue().fullSpec.equals(partition.getSpec()))
+ .findAny().ifPresent(entry -> {
+ entry.getValue().partition = partition;
+ entry.getValue().hasOldPartition = true;
+ });
+ }
+ // no need to fetch partition again in tasks since we have already
fetched partitions
+ // info in getPartitionsByNames()
+ fetchPartitionInfo = false;
+ } catch (HiveException e) {
+ // Failed to fetch partitions in some cases (e.g., partition number
limit)
+ LOG.warn("Fetching partitions by names failed.", e);
Review Comment:
I didn't see any fallback code block. BTW, i think no one will care about
the warn log, so client side(spark & hiveserver2) maybe miss this warn
exception, and then they maybe lose some partition data.
Therefore, if this PR must change the client behavior, such as the
Introduced `partition limit exception` , (see the previous ci
http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-5063/1/tests/
), we need throw this exception. But as i said above, it would better to not
to introduce this incompatible behavior if possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
