zabetak commented on code in PR #5155:
URL: https://github.com/apache/hive/pull/5155#discussion_r1537457971
##########
ql/src/test/queries/clientpositive/execute_query_string.q:
##########
@@ -0,0 +1,3 @@
+create table prepareexecute(a int, b int);
+prepare pcount from select count(*) from prepareexecute where a > ?;
+execute pcount using '200';
Review Comment:
The new test is redundant since the same query pattern appears in other .q
files and the effects of the changes are clearly visible in the .q.out changes.
##########
ql/src/test/results/clientpositive/llap/prepare_plan.q.out:
##########
@@ -128,11 +128,11 @@ STAGE PLANS:
Processor Tree:
ListSink
-PREHOOK: query: prepare pcount from select count(*) from src where key > ?
Review Comment:
The changes in the .q.out file are the expected ones however there seems to
be something missing from the prepare statement implementation. After the
changes introduced here the `query: prepare` pattern does not appear at all in
the .q.out files.
Is this normal? Should we log a follow-up ticket?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
