ayushtkn commented on code in PR #5173:
URL: https://github.com/apache/hive/pull/5173#discussion_r1546453615
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java:
##########
@@ -1530,7 +1530,11 @@ public void truncateTable(String dbDotTableName,
Map<String, String> partSpec, L
List<String> partNames = ((null == partSpec)
? null : getPartitionNames(table.getDbName(),
table.getTableName(), partSpec, (short) -1));
if (snapshot == null) {
- getMSC().truncateTable(table.getDbName(), table.getTableName(),
partNames);
+ if (table.getSnapshotRef() != null &&
table.getStorageHandler().isTableMetaRefSupported()) {
Review Comment:
we can do but we already have on getFullTableName
```
public TableName getFullTableName() {
```
this will create a ``TableName`` object & return, from which we get the
concatenated table name, so object creation will redundant & Java won't let us
create another ``getFullTableName`` with just different return type, will any
other name work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
