zratkai commented on code in PR #5014:
URL: https://github.com/apache/hive/pull/5014#discussion_r1555697225
##########
ql/src/test/queries/clientpositive/udf_from_utc_timestamp.q:
##########
@@ -8,8 +8,6 @@ from_utc_timestamp('2012-02-11 04:30:00', 'PST'),
from_utc_timestamp('2012-02-11 04:30:00', 'Europe/Moscow'),
from_utc_timestamp('2012-02-11 04:30:00', 'GMT+8'),
from_utc_timestamp('2012-02-11 04:30:00', 'GMT'),
-from_utc_timestamp('2012-02-11 04:30:00', ''),
-from_utc_timestamp('2012-02-11 04:30:00', '---'),
Review Comment:
This are invalid formats. Previously in such cases UTC was used, but now
instead an exception is thrown:
java.time.DateTimeException: Invalid ID for ZoneOffset, invalid format
But it can not be tested here. It is tested with
TestGenericUDFFromUtcTimestamp.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
