kuczoram opened a new pull request, #5192: URL: https://github.com/apache/hive/pull/5192
Refactored the compaction query generation logic. The main idea was to separate the code parts responsibe for different compaction types. So far everything was handled by one class, therefore it was hard to read and changing the logic for one compaction type might caused side effects on other types. There was an older PR for this change (https://github.com/apache/hive/pull/4952), but it got far away from the master branch, and it was easier to create a new PR. In this PR, I addressed all the comments from the previous one. Also added unit test for the query generation. I ran these tests before the refactoring as well, to be sure that no query output was changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
