kasakrisz commented on code in PR #5231:
URL: https://github.com/apache/hive/pull/5231#discussion_r1589235596
##########
hplsql/src/main/java/org/apache/hive/hplsql/Exec.java:
##########
@@ -1028,9 +1028,13 @@ void cleanup() {
* Output information about unhandled exceptions
*/
public void printExceptions() {
+ List<Signal> userDefinedSignals = new ArrayList<>();
Review Comment:
Is it allowed to add the same Signal more than one times?
Does the order of `Signals` matter?
##########
hplsql/src/main/java/org/apache/hive/hplsql/Exec.java:
##########
@@ -1044,6 +1048,12 @@ public void printExceptions() {
trace(null, "Signal: " + sig.type);
}
}
+ // if there are any user defined signals then push them back to signals
stack to handle them later.
+ if (userDefinedSignals.size() > 0) {
+ for (int i = userDefinedSignals.size() - 1; i >= 0; i--) {
Review Comment:
Is this check necessary? If `userDefinedSignals` is empty the loop doesn't
executed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
