simhadri-g commented on code in PR #5241:
URL: https://github.com/apache/hive/pull/5241#discussion_r1595485775
##########
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/timestamp/NanoTimeUtils.java:
##########
@@ -102,10 +106,22 @@ public static Timestamp getTimestamp(NanoTime nt, ZoneId
targetZone, boolean leg
JulianDate jDateTime;
jDateTime = JulianDate.of((double) julianDay);
+ LocalDateTime localDateTime;
Review Comment:
Not exactly, we don't need to have this check for every leap year.
The Julian calendar defines a leap year as once every four years. The
Gregorian calendar modified the addition of leap days, such that a century year
was only counted as a leap year if it was also divisible by 400.
So according to julian calender the year 200 or 300 is a leap year but they
are not a leap year according to according to Gregorian calendar. That is why
we are seeing this issue, this is an edge case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
