zabetak opened a new pull request, #5244: URL: https://github.com/apache/hive/pull/5244
### What changes were proposed in this pull request? 1. Relax the assertion to not throw an error when the cluster does not contain a `ConventionTraitDef` (`HepPlanner`). 2. Add tests to ensure that it is possible to create a `HiveTableScan` with `VolcanoPlanner` and `HepPlanner` and the expected convention is returned. ### Why are the changes needed? The HepPlanner is heavily used by the optimizer so it makes to be able to create a HiveTableScan with its respective cluster without residing in workarounds (such as requiring the creation of a VolcanoPlanner and obtaining the cluster from there). More details under HIVE-28252. ### Does this PR introduce _any_ user-facing change? No, anyways assertions are not enabled in production code. ### Is the change a dependency upgrade? No ### How was this patch tested? ``` mvn test -Dtest=TestHiveTableScan ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
