simhadri-g commented on code in PR #5241:
URL: https://github.com/apache/hive/pull/5241#discussion_r1599930408
##########
ql/src/test/queries/clientpositive/timestamp_julian.q:
##########
@@ -0,0 +1,22 @@
+--! qt:timezone:Asia/Singapore
+
+-- Test 1
+-- insert into default.test_sgt700 values ('0200-03-01 00:00:00')
+CREATE EXTERNAL TABLE `TEST_SGT`(`currtime` timestamp) ROW FORMAT SERDE
'org.apache.hadoop.hive.ql.io.parquet.serde.ParquetHiveSerDe' STORED AS
Review Comment:
Done, I have added unit test that covers testing 1st march across 3000 years
.
Also, can we please keep both q test and unit test ?
The datafiles for q tests are only 400 bytes each.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
