abstractdog commented on code in PR #5195:
URL: https://github.com/apache/hive/pull/5195#discussion_r1606063473
##########
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java:
##########
@@ -1727,14 +1727,15 @@ private void populateAndCacheStripeDetails() throws
IOException {
private long computeProjectionSize(List<OrcProto.Type> fileTypes,
List<OrcProto.ColumnStatistics> stats, boolean[] fileIncluded) throws
FileFormatException {
List<Integer> internalColIds = Lists.newArrayList();
+ int rootColumn = 0;
Review Comment:
rootColumn doesn't seem to change, which is strange, I guess this is more
like a constant instead
##########
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java:
##########
@@ -1727,14 +1727,15 @@ private void populateAndCacheStripeDetails() throws
IOException {
private long computeProjectionSize(List<OrcProto.Type> fileTypes,
List<OrcProto.ColumnStatistics> stats, boolean[] fileIncluded) throws
FileFormatException {
List<Integer> internalColIds = Lists.newArrayList();
+ int rootColumn = 0;
Review Comment:
rootColumn variable doesn't seem to change, which is strange, I guess this
is more like a constant instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
