abstractdog commented on PR #5153: URL: https://github.com/apache/hive/pull/5153#issuecomment-2133166307
> LGTM, but I would ask for @abstractdog opinion 1. can we fix the "SUFFLE" typos if we're already touching this part? 2. can you please share more details about the manual testing? real cluster vs. some mini llap cluster? Can this happen with a MiniLlapCluster as a test? tez has TestSecureShuffle for this, which would be hard to adapt, but hive's own mini llap based tests make sense to me, as this is a new feature (at least in hive) consider use tez unit test for guidance with setting up SSL: https://github.com/apache/tez/blob/30e9cdbff7adb75c3553d5cbb8515761a7231e07/tez-tests/src/test/java/org/apache/tez/test/TestSecureShuffle.java#L241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
