InvisibleProgrammer commented on code in PR #5265: URL: https://github.com/apache/hive/pull/5265#discussion_r1618572635
########## ql/src/test/results/clientpositive/llap/file_with_delimiter.q.out: ########## @@ -0,0 +1,63 @@ +PREHOOK: query: create external table test(code string,name string) +ROW FORMAT SERDE + 'org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe' + WITH SERDEPROPERTIES ( + 'field.delim'='\t') + STORED AS INPUTFORMAT + 'org.apache.hadoop.mapred.TextInputFormat' + OUTPUTFORMAT + 'org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat' +#### A masked pattern was here #### + TBLPROPERTIES ( + 'skip.header.line.count'='1', + 'textinputformat.record.delimiter'='|') +PREHOOK: type: CREATETABLE +#### A masked pattern was here #### +PREHOOK: Output: database:default +PREHOOK: Output: default@test +POSTHOOK: query: create external table test(code string,name string) +ROW FORMAT SERDE + 'org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe' + WITH SERDEPROPERTIES ( + 'field.delim'='\t') + STORED AS INPUTFORMAT + 'org.apache.hadoop.mapred.TextInputFormat' + OUTPUTFORMAT + 'org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat' +#### A masked pattern was here #### + TBLPROPERTIES ( + 'skip.header.line.count'='1', + 'textinputformat.record.delimiter'='|') +POSTHOOK: type: CREATETABLE +#### A masked pattern was here #### +POSTHOOK: Output: database:default +POSTHOOK: Output: default@test +PREHOOK: query: LOAD DATA LOCAL INPATH '../../data/files/header_footer_table_4/0003.txt' INTO TABLE test +PREHOOK: type: LOAD +#### A masked pattern was here #### +PREHOOK: Output: default@test +POSTHOOK: query: LOAD DATA LOCAL INPATH '../../data/files/header_footer_table_4/0003.txt' INTO TABLE test +POSTHOOK: type: LOAD +#### A masked pattern was here #### +POSTHOOK: Output: default@test +PREHOOK: query: Select count(*) from test +PREHOOK: type: QUERY +PREHOOK: Input: default@test +#### A masked pattern was here #### +POSTHOOK: query: Select count(*) from test +POSTHOOK: type: QUERY +POSTHOOK: Input: default@test +#### A masked pattern was here #### +3 +PREHOOK: query: Select * from test +PREHOOK: type: QUERY +PREHOOK: Input: default@test +#### A masked pattern was here #### +POSTHOOK: query: Select * from test +POSTHOOK: type: QUERY +POSTHOOK: Input: default@test +#### A masked pattern was here #### +A AAAA NULL Review Comment: > I am not sure about the document, if we have any. But the output for the query is same, with or without this PR. What is the reason of the change if the output is the same then? Can you add a test that tests the change? Also, if you can write a short summary about the functionality, I would be happy to add it to the documentation. I have write permission in the Hive wiki. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
