zabetak commented on code in PR #5172:
URL: https://github.com/apache/hive/pull/5172#discussion_r1618726412
##########
beeline/pom.xml:
##########
@@ -276,6 +276,11 @@
<artifactId>maven-shade-plugin.log4j2-cachefile-transformer</artifactId>
<version>2.1</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-core</artifactId>
+ <version>${log4j2.version}</version>
+ </dependency>
Review Comment:
Then the scope of this PR is wider than what is currently described in the
ticket. Please adapt the description accordingly.
It seems that the PR wants to avoid also using log4j 2 versions lower than
X. In that case, I think we will need to revisit the enforcement rules to cover
that case as well otherwise we cannot tell if it is handled properly in all
modules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
