mayankkunwar commented on code in PR #5269: URL: https://github.com/apache/hive/pull/5269#discussion_r1619882867
########## ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java: ########## @@ -213,15 +214,46 @@ public final List<String> filterCatalogs(List<String> catalogs) throws MetaExcep @Override @Deprecated - public List<TableMeta> filterTableMetas(String catName, String dbName,List<TableMeta> tableMetas) + public List<TableMeta> filterTableMetas(String catName, String dbName, List<TableMeta> tableMetas) Review Comment: In this method, I see that "catName" is never used, so what would be the reason to have this parameter? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
