deniskuzZ commented on code in PR #5251:
URL: https://github.com/apache/hive/pull/5251#discussion_r1624745450
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergMergeTaskProperties.java:
##########
@@ -42,14 +46,23 @@ public Path getTmpLocation() {
return new Path(location + "/data/");
}
- public StorageFormatDescriptor getStorageFormatDescriptor() throws
IOException {
- FileFormat fileFormat =
FileFormat.fromString(properties.getProperty(TableProperties.DEFAULT_FILE_FORMAT,
- TableProperties.DEFAULT_FILE_FORMAT_DEFAULT));
- StorageFormatDescriptor descriptor =
storageFormatFactory.get(fileFormat.name());
- if (descriptor == null) {
- throw new IOException("Unsupported storage format descriptor");
+ @Override
+ public MergeSplitProperties getSplitProperties() throws IOException {
+ String tableName = properties.getProperty(Catalogs.NAME);
+ String snapshotRef = properties.getProperty(Catalogs.SNAPSHOT_REF);
+ Configuration configuration = SessionState.getSessionConf();
+ List<JobContext> originalContextList =
IcebergTableUtil.generateJobContext(configuration, tableName, snapshotRef);
Review Comment:
isn't that expensive?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
