abstractdog commented on code in PR #5265:
URL: https://github.com/apache/hive/pull/5265#discussion_r1625623198


##########
ql/src/test/queries/clientpositive/file_with_delimiter.q:
##########
@@ -0,0 +1,22 @@
+create external table test(code string,name string)
+ROW FORMAT SERDE
+   'org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe'
+ WITH SERDEPROPERTIES (
+   'field.delim'='\t')
+ STORED AS INPUTFORMAT
+   'org.apache.hadoop.mapred.TextInputFormat'
+ OUTPUTFORMAT
+   'org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat'
+   location '${system:test.tmp.dir}/test'
+ TBLPROPERTIES (
+   'skip.header.line.count'='1',
+   'textinputformat.record.delimiter'='|');
+
+
+   LOAD DATA LOCAL INPATH '../../data/files/header_footer_table_4/0003.txt' 
INTO TABLE test;

Review Comment:
   nit: mixed-case is weird: "Select", "create", "STORED", please pick one and 
stick to it, no matter if it's full uppercase or lowercase



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to