zhangbutao commented on code in PR #5292:
URL: https://github.com/apache/hive/pull/5292#discussion_r1639556639
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/database/create/CreateDatabaseOperation.java:
##########
@@ -44,6 +44,9 @@ public CreateDatabaseOperation(DDLOperationContext context,
CreateDatabaseDesc d
@Override
public int execute() throws HiveException {
+ if (desc.getIfNotExists() &&
context.getDb().databaseExists(desc.getName())) {
Review Comment:
Should we also follow `table if not exist` check pattern, just do a check in
https://github.com/apache/hive/blob/3eb56ecae056d36370ff0ee9a0936c28b431724a/ql/src/java/org/apache/hadoop/hive/ql/ddl/database/create/CreateDatabaseAnalyzer.java#L47-L50
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
