deniskuzZ commented on code in PR #5251:
URL: https://github.com/apache/hive/pull/5251#discussion_r1644175171
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergMergeTaskProperties.java:
##########
@@ -42,14 +45,23 @@ public Path getTmpLocation() {
return new Path(location + "/data/");
}
- public StorageFormatDescriptor getStorageFormatDescriptor() throws
IOException {
- FileFormat fileFormat =
FileFormat.fromString(properties.getProperty(TableProperties.DEFAULT_FILE_FORMAT,
- TableProperties.DEFAULT_FILE_FORMAT_DEFAULT));
- StorageFormatDescriptor descriptor =
storageFormatFactory.get(fileFormat.name());
- if (descriptor == null) {
- throw new IOException("Unsupported storage format descriptor");
+ @Override
+ public Map<Path, Object> getSplitProperties() throws IOException {
Review Comment:
why not to return `Properties` object in that case? I think it's better to
use proper types/names and avoid casting latter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
