wecharyu commented on code in PR #5310:
URL: https://github.com/apache/hive/pull/5310#discussion_r1644233537
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java:
##########
@@ -1007,17 +1012,10 @@ public void close() {
try {
if (null != client) {
client.shutdown();
- if ((transport == null) || !transport.isOpen()) {
- final int newCount = connCount.decrementAndGet();
- LOG.info("Closed a connection to metastore, current connections: {}",
- newCount);
- }
}
} catch (TException e) {
LOG.debug("Unable to shutdown metastore client. Will try closing
transport directly.", e);
}
- // Transport would have got closed via client.shutdown(), so we dont need
this, but
Review Comment:
`client.shutdown()` calls would not close transport in client side, we must
close transport explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
