soumyakanti3578 commented on code in PR #5291: URL: https://github.com/apache/hive/pull/5291#discussion_r1644793716
########## iceberg/iceberg-handler/src/test/queries/positive/delete_iceberg_mixed.q: ########## @@ -6,6 +6,8 @@ --! qt:replace:/("removed-files-size":")\d+/$1#FileSize#/ -- create an unpartitioned table with skip delete data set to false +set hive.cbo.fallback.strategy=NEVER; Review Comment: This test falls back to non-cbo path due to `where null`: ``` [2024-06-06T22:35:22.382Z] delete from ice01 where null [2024-06-06T22:35:22.382Z] fname=delete_iceberg_mixed.q [2024-06-06T22:35:22.382Z] [2024-06-06T22:35:22.382Z] See ./ql/target/tmp/log/hive.log or ./itests/qtest/target/tmp/log/hive.log, or check ./ql/target/surefire-reports or ./itests/qtest/target/surefire-reports/ for specific test cases logs. [2024-06-06T22:35:22.382Z] org.apache.hadoop.hive.ql.optimizer.calcite.CalciteSemanticException: Filter expression with non-boolean return type. [2024-06-06T22:35:22.382Z] at org.apache.hadoop.hive.ql.parse.CalcitePlanner$CalcitePlannerAction.genFilterRelNode(CalcitePlanner.java:3212) [2024-06-06T22:35:22.382Z] at org.apache.hadoop.hive.ql.parse.CalcitePlanner$CalcitePlannerAction.genFilterRelNode(CalcitePlanner.java:3198) [2024-06-06T22:35:22.382Z] at org.apache.hadoop.hive.ql.parse.CalcitePlanner$CalcitePlannerAction.genFilterRelNode(CalcitePlanner.java:3395) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org