zabetak commented on code in PR #5315:
URL: https://github.com/apache/hive/pull/5315#discussion_r1650806332
##########
itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/MiniHiveKdc.java:
##########
@@ -194,9 +194,6 @@ public static MiniHS2 getMiniHS2WithKerb(MiniHiveKdc
miniHiveKdc, HiveConf hiveC
.withConf(hiveConf)
.withMiniKdc(hivePrincipal,
hiveKeytab)
.withAuthenticationType(authType);
- if (HiveServer2.isHttpTransportMode(hiveConf)) {
Review Comment:
The JDBC URL is usually obtained from `MiniHS2#getJdbcURL()` so the
server/client configs should be aligned.
Nevertheless to simplify the review of this PR I reverted the changes here
and in MiniHS2 and added the same `isHttpTransportMode` logic in the the other
static factory method that is used in this test
(https://github.com/apache/hive/pull/5315/commits/add40a8b80d2be8ce5f03022c4206259bdb421de
).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
