cxzl25 commented on code in PR #5218:
URL: https://github.com/apache/hive/pull/5218#discussion_r1665345108
##########
pom.xml:
##########
@@ -180,8 +180,8 @@
<mysql.version>8.0.31</mysql.version>
<postgres.version>42.7.3</postgres.version>
<oracle.version>21.3.0.0</oracle.version>
- <opencsv.version>2.3</opencsv.version>
- <orc.version>1.8.5</orc.version>
+ <opencsv.version>5.9</opencsv.version>
Review Comment:
> how do we handle repeated nulls in ORC?
`isRepeating=true, noNulls=false, isNull[]=true`
<img width="471" alt="image"
src="https://github.com/apache/hive/assets/3898450/b8ddde56-fccc-4661-920e-529a6f13272e";>
> Also why logic is different from, for example, `DoubleColumnVector`, where
we set `result.isRepeating = false;` at the beginning of `nextVector`
Because the formats for storing data are different, DecimalTreeReader and
DoubleTreeReader behave differently.
org.apache.orc.impl.TreeReaderFactory.DecimalTreeReader#nextVector
```java
// read the scales
scaleReader.nextVector(result, scratchScaleVector, batchSize);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
