kasakrisz commented on code in PR #5196:
URL: https://github.com/apache/hive/pull/5196#discussion_r1665400657
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveFilter.java:
##########
@@ -72,6 +78,22 @@ public HiveFilter(RelOptCluster cluster, RelTraitSet traits,
RelNode child, RexN
super(cluster, TraitsUtil.getDefaultTraitSet(cluster), child, condition);
this.correlationInfos = new CorrelationInfoSupplier(getCondition());
}
+
+ @Override
+ public RelWriter explainTerms(RelWriter pw) {
+ // Remove this method after upgrading Calcite to 1.35+
Review Comment:
> write project properties with properties-maven-plugin to
ql/src/main/resources/, and read the calcite version from there
It can work.
However we already have constants needs to be manually modified at a Calcite
upgrade:
https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/Bug.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
