asolimando commented on code in PR #5249: URL: https://github.com/apache/hive/pull/5249#discussion_r1670492165
########## ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTBuilder.java: ########## @@ -77,9 +77,11 @@ public static ASTNode table(final RelNode scan) { assert hts != null; RelOptHiveTable hTbl = (RelOptHiveTable) hts.getTable(); - ASTBuilder tableNameBuilder = ASTBuilder.construct(HiveParser.TOK_TABNAME, "TOK_TABNAME") - .add(HiveParser.Identifier, hTbl.getHiveTableMD().getDbName()) - .add(HiveParser.Identifier, hTbl.getHiveTableMD().getTableName()); + ASTBuilder tableNameBuilder = ASTBuilder.construct(HiveParser.TOK_TABNAME, "TOK_TABNAME"); + if (!hTbl.getHiveTableMD().isTemporary()) { Review Comment: The refactored version is easier to follow, no further comments are needed in the code I'd say, resolving -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org