abstractdog commented on PR #5331: URL: https://github.com/apache/hive/pull/5331#issuecomment-2233034293
> yes - it was a surprise to me as well that k8s doesn't support `VOLUME`-s; the default config copy was a courtesy to make it usable right away if it gets deployed at a new location > > I think putting this into the main repo is not the best - as you will need to deploy it and push the image to see what happens...so you will at most will be committing to the repo as an after-tought....keeping a separate un-confined repo will make it easier to track what and when was changed - but I might be alone with this view... I feel that keeping this image in the main repo is the way to go how to manage the challenges that come with this approach is a different question, regarding which I have no idea now, honestly :) this approach is not strictly "after-tought", only if it's proven to be impossible to test the Dockerfile changes in advance, I hope it's not the case, thinking about a github action to create and push an image with a custom tag from a PR like this (automatically or driven by a label) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
