chinnaraolalam commented on code in PR #5000:
URL: https://github.com/apache/hive/pull/5000#discussion_r1685240923
##########
ql/src/test/org/apache/hadoop/hive/ql/TestTxnLoadData.java:
##########
@@ -394,16 +394,16 @@ public void loadDataPartitioned() throws Exception {
*/
@Test
public void testValidations() throws Exception {
- runStatementOnDriver("drop table if exists T");
- runStatementOnDriver("drop table if exists Tstage");
Review Comment:
Yes lowercased inpath dir should work, but need to comment why we are
lowering the table name from camel notation without using as it is, it will
help for further extension of the test case. IIUC test case scenario wise
camel notation of table name is not needed.
All the test cases in this class uses camel notation, only to make it
consistent I agree with denis maintain camel notation of table name here also
and lowercased only inpath dir.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
