SourabhBadhya commented on code in PR #5254:
URL: https://github.com/apache/hive/pull/5254#discussion_r1686425710
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/vector/HiveBatchIterator.java:
##########
@@ -53,7 +54,7 @@ public final class HiveBatchIterator implements
CloseableIterator<HiveBatchConte
private Map<Integer, ?> idToConstant;
HiveBatchIterator(RecordReader<NullWritable, VectorizedRowBatch>
recordReader, JobConf job,
- int[] partitionColIndices, Object[] partitionValues, Map<Integer, ?>
idToConstant) {
+ int[] partitionColIndices, Object[] partitionValues,
Map<Integer, ?> idToConstant) {
Review Comment:
Removed.
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/vector/HiveVectorizedReader.java:
##########
@@ -253,7 +254,7 @@ private static RecordReader<NullWritable,
VectorizedRowBatch> parquetRecordReade
private static CloseableIterable<HiveBatchContext>
createVectorizedRowBatchIterable(
RecordReader<NullWritable, VectorizedRowBatch> hiveRecordReader, JobConf
job, int[] partitionColIndices,
- Object[] partitionValues, Map<Integer, ?> idToConstant) {
+ Object[] partitionValues, Map<Integer, ?> idToConstant, PartitionSpec
partitionSpec) {
Review Comment:
Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
