deniskuzZ commented on code in PR #5328:
URL: https://github.com/apache/hive/pull/5328#discussion_r1688257846
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -2112,4 +2118,10 @@ public List<FileStatus>
getMergeTaskInputFiles(Properties properties) throws IOE
public MergeTaskProperties getMergeTaskProperties(Properties properties) {
return new IcebergMergeTaskProperties(properties);
}
+
+ @Override
+ public boolean
isUndergonePartitionEvolution(org.apache.hadoop.hive.ql.metadata.Table
hmsTable) {
+ Table table = IcebergTableUtil.getTable(conf, hmsTable.getTTable());
+ return table.specs().size() > 1;
Review Comment:
`HiveIcebergStorageHandler#hasUndergonePartitionEvolution` has similar
logic, can we reuse?
number of specs doesn't mean that all of them are referenced
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
