soumyakanti3578 commented on code in PR #5379:
URL: https://github.com/apache/hive/pull/5379#discussion_r1702282274
##########
ql/src/test/org/apache/hadoop/hive/ql/optimizer/calcite/rules/TestRuleHelper.java:
##########
@@ -88,16 +83,16 @@ public static RelBuilder
buildRelBuilder(AbstractRelOptPlanner planner,
return HiveRelFactories.HIVE_BUILDER.create(optCluster, schemaMock);
}
- static RexNode eq(RelBuilder relBuilder, String field, Number value) {
+ public static RexNode eq(RelBuilder relBuilder, String field, Number value) {
return relBuilder.call(SqlStdOperatorTable.EQUALS,
relBuilder.field(field), relBuilder.literal(value));
}
- static RexNode or(RelBuilder relBuilder, RexNode... args) {
+ public static RexNode or(RelBuilder relBuilder, RexNode... args) {
return relBuilder.call(SqlStdOperatorTable.OR, args);
}
- static RexNode and(RelBuilder relBuilder, RexNode... args) {
+ public static RexNode and(RelBuilder relBuilder, RexNode... args) {
Review Comment:
Thanks, I will use the APIs from RelBuilder instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
