deniskuzZ commented on code in PR #5328:
URL: https://github.com/apache/hive/pull/5328#discussion_r1703664072
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java:
##########
@@ -778,10 +778,28 @@ default Optional<ErrorMsg>
isEligibleForCompaction(org.apache.hadoop.hive.ql.met
throw new UnsupportedOperationException("Storage handler does not support
validating eligibility for compaction");
}
+ /**
+ * Returns partitions names for the current table spec that correspond to
the provided partition spec.
+ * @param hmsTable {@link org.apache.hadoop.hive.ql.metadata.Table} table
metadata stored in Hive Metastore
+ * @param partitionSpec Map of Strings {@link java.util.Map} partition
specification
+ * @return List of partition names
+ */
default List<String>
getPartitionNames(org.apache.hadoop.hive.ql.metadata.Table hmsTable,
Map<String, String> partitionSpec) throws SemanticException {
+ return getPartitionNames(hmsTable, partitionSpec, true);
+ }
+
+ /**
+ * Returns partitions names that correspond to the provided partition spec.
+ * @param hmsTable {@link org.apache.hadoop.hive.ql.metadata.Table} table
metadata stored in Hive Metastore
+ * @param partitionSpec Map of Strings {@link java.util.Map} partition
specification
+ * @param latestSpecOnly Tells whether to return partition names for the
latest spec only or for past specs too
+ * @return List of partition names
+ */
+ default List<String>
getPartitionNames(org.apache.hadoop.hive.ql.metadata.Table hmsTable,
Review Comment:
why do we need to expose it in API if it's not used outside of
StorageHandler?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
