soumyakanti3578 commented on code in PR #5307:
URL: https://github.com/apache/hive/pull/5307#discussion_r1733176693
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java:
##########
@@ -939,11 +940,8 @@ Pair<Boolean, String> canCBOHandleAst(ASTNode ast, QB qb,
PreCboCtx cboCtx) {
msg += "is not a query with at least one source table "
+ " or there is a subquery without a source table, or CTAS, or
insert; ";
}
- if (!noBadTokens) {
- msg += "has unsupported tokens; ";
- }
- if (msg.isEmpty()) {
- msg += "has some unspecified limitations; ";
+ if (Boolean.TRUE.equals(unsupportedFeatures.getKey())) {
+ msg += "has unsupported feature [" + unsupportedFeatures.getValue() +
"]; ";
Review Comment:
I added "feature" instead of "tokens" because we are now checking for the
function "CREATE_UNION" too. Let me know what you think about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
