simhadri-g commented on code in PR #5404:
URL: https://github.com/apache/hive/pull/5404#discussion_r1736025764
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/CheckResult.java:
##########
@@ -95,22 +103,27 @@ public Set<PartitionResult> getPartitionsNotInMs() {
* @param partitionsNotInMs
* a list of partitions not found in the metastore
*/
+ @SuppressFBWarnings(value = "EI_EXPOSE_REP2", justification =
"intended_to_do")
public void setPartitionsNotInMs(Set<PartitionResult> partitionsNotInMs) {
this.partitionsNotInMs = partitionsNotInMs;
}
+ @SuppressFBWarnings(value = "EI_EXPOSE_REP", justification =
"intended_to_do")
public Set<PartitionResult> getExpiredPartitions() {
return expiredPartitions;
}
+ @SuppressFBWarnings(value = "EI_EXPOSE_REP2", justification =
"intended_to_do")
public void setExpiredPartitions(final Set<PartitionResult>
expiredPartitions) {
this.expiredPartitions = expiredPartitions;
}
+ @SuppressFBWarnings(value = "EI_EXPOSE_REP", justification =
"intended_to_do")
Review Comment:
Why are we suppressing warnings?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
