deniskuzZ commented on code in PR #4336:
URL: https://github.com/apache/hive/pull/4336#discussion_r1740779538
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/CustomPartitionVertex.java:
##########
@@ -533,83 +536,75 @@ private FileSplit
getFileSplitFromEvent(InputDataInformationEvent event) throws
private Multimap<Integer, InputSplit> getBucketSplitMapForPath(String
inputName,
Map<String, Set<FileSplit>> pathFileSplitsMap) {
+ boolean isSMBJoin = numInputsAffectingRootInputSpecUpdate != 1;
+ boolean isMainWork = mainWorkName.isEmpty() ||
inputName.compareTo(mainWorkName) == 0;
+ Preconditions.checkState(
+ (isMainWork || (isSMBJoin && inputToBucketMap != null &&
inputToBucketMap.containsKey(inputName))),
Review Comment:
redundant parentheses + use build-in formatting
````
Preconditions.checkState(
isMainWork || isSMBJoin && inputToBucketMap != null &&
inputToBucketMap.containsKey(inputName),
"CustomPartitionVertex.inputToBucketMap is not defined for {}",
inputName)
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
