abstractdog commented on code in PR #5404: URL: https://github.com/apache/hive/pull/5404#discussion_r1741561482
########## data/conf/llap/hive-site.xml: ########## @@ -49,7 +49,7 @@ <!-- the Vertex resource, so this has to be defined in order to get consistent test results --> <property> <name>hive.tez.container.size</name> - <value>128</value> + <value>256</value> Review Comment: this explanation makes sense as long as it's in a tez container, however, in case of llap (this is something .../llap/...), this setting doesn't have a direct effect on memory consumption, because the LLAP daemon runs locally in the same surefire JVM process are we sure that OOM issues show without this setting? isn't it possible that this change has been borrowed from another test config (where it was really necessary) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
