abstractdog commented on code in PR #5399:
URL: https://github.com/apache/hive/pull/5399#discussion_r1745270205
##########
service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java:
##########
@@ -289,7 +287,7 @@ protected void doPost(HttpServletRequest request,
HttpServletResponse response)
} else {
try {
LOG.error("Login attempt is failed for user : " +
- getUsername(request) + ". Error Messsage :" + e.getMessage());
+ httpAuthService.getUsername(request) + ". Error Messsage :" +
e.getMessage());
} catch (Exception ex) {
// Ignore Exception
Review Comment:
Are we aware of any exceptions happening here? if the goal is to keep doPost
method signature free from exceptions, we should throw a:
```
new RuntimeException(ex)
```
ignore it is always dangerous
+ minor type: Messsage -> Message
##########
service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java:
##########
@@ -289,7 +287,7 @@ protected void doPost(HttpServletRequest request,
HttpServletResponse response)
} else {
try {
LOG.error("Login attempt is failed for user : " +
- getUsername(request) + ". Error Messsage :" + e.getMessage());
+ httpAuthService.getUsername(request) + ". Error Messsage :" +
e.getMessage());
} catch (Exception ex) {
// Ignore Exception
Review Comment:
Are we aware of any exceptions happening here? if the goal is to keep doPost
method signature free from exceptions, we should throw a:
```
new RuntimeException(ex)
```
ignore it is always dangerous
+ minor typo: Messsage -> Message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
