tanishq-chugh commented on code in PR #5404:
URL: https://github.com/apache/hive/pull/5404#discussion_r1746586548
##########
common/src/java/org/apache/hadoop/hive/common/cli/ShellCmdExecutor.java:
##########
@@ -22,12 +22,14 @@
import java.io.PrintStream;
import org.apache.hive.common.util.StreamPrinter;
+import org.apache.hive.common.util.SuppressFBWarnings;
public class ShellCmdExecutor {
private String cmd;
private PrintStream out;
private PrintStream err;
+ @SuppressFBWarnings(value = "EI_EXPOSE_REP2", justification =
"intended_to_do")
Review Comment:
@zhangbutao I have added the reasoning behind this change in the comment
above:
[https://github.com/apache/hive/pull/5404#discussion_r1736025764](https://github.com/apache/hive/pull/5404#discussion_r1736025764)
. Please check that out. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
