dengzhhu653 commented on code in PR #5319:
URL: https://github.com/apache/hive/pull/5319#discussion_r1750002979


##########
service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java:
##########
@@ -110,6 +116,15 @@ public void runInternal() throws HiveSQLException {
       String[] tokens = command.split("\\s");
       String commandArgs = command.substring(tokens[0].length()).trim();
 
+      // For ShowProcesslistProcessor , session and operation level details  
are fetched
+      // from SessionManager which can not be accessed from commandProcessor. 
So, we need to create DTO here..
+      if (commandProcessor instanceof ShowProcesslistProcessor) {
+        List<ProcessListInfo> liveQueries = getLiveQueryInfos(parentSession);

Review Comment:
   nit: how about moving the `getLiveQueryInfos(parentSession)` to 
`ShowProcesslistProcessor`, e.g, change the setup(liveQueries) to 
`setup(parentSession)`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to