deniskuzZ commented on code in PR #5386:
URL: https://github.com/apache/hive/pull/5386#discussion_r1756791382
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -1443,6 +1449,25 @@ static void overlayTableProperties(Configuration
configuration, TableDesc tableD
map.remove("columns.comments");
}
+ @Override
+ public void validateCurrentSnapshot(TableDesc tableDesc) {
+ if (conf.getBoolean(ConfigProperties.LOCK_HIVE_ENABLED,
TableProperties.HIVE_LOCK_ENABLED_DEFAULT) ||
+ !HiveConf.getBoolVar(conf, ConfVars.HIVE_TXN_EXT_LOCKING_ENABLED)) {
+ return;
+ }
+ Table table = IcebergTableUtil.getTable(conf, tableDesc.getProperties());
Review Comment:
we compare the state of the table in a cache (populated at compile time)
with the latest one
````
((BaseTable) table).operations().refresh()
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
