deniskuzZ commented on code in PR #5436:
URL: https://github.com/apache/hive/pull/5436#discussion_r1762571233
##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -209,20 +206,46 @@ public boolean dropTable(TableIdentifier identifier,
boolean purge) {
@Override
public void renameTable(TableIdentifier from, TableIdentifier originalTo) {
+ renameTableOrView(from, originalTo, HiveOperationsBase.ContentType.TABLE);
+ }
+
+ private List<TableIdentifier> listIcebergTables(
+ List<String> tableNames, Namespace namespace, String tableTypeProp)
+ throws TException, InterruptedException {
+ List<Table> tableObjects =
+ clients.run(client ->
client.getTableObjectsByName(namespace.level(0), tableNames));
+ return tableObjects.stream()
+ .filter(
Review Comment:
could we keep the original formatting
##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -209,20 +206,46 @@ public boolean dropTable(TableIdentifier identifier,
boolean purge) {
@Override
public void renameTable(TableIdentifier from, TableIdentifier originalTo) {
+ renameTableOrView(from, originalTo, HiveOperationsBase.ContentType.TABLE);
+ }
+
+ private List<TableIdentifier> listIcebergTables(
+ List<String> tableNames, Namespace namespace, String tableTypeProp)
+ throws TException, InterruptedException {
+ List<Table> tableObjects =
+ clients.run(client ->
client.getTableObjectsByName(namespace.level(0), tableNames));
+ return tableObjects.stream()
+ .filter(
Review Comment:
could we keep the original formatting?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
