KiranVelumuri commented on PR #5309:
URL: https://github.com/apache/hive/pull/5309#issuecomment-2362874736

   > I understand that due to bugs the tests may fail in certain environments.
   > 
   > If the main motivation of this PR is to avoid the failures when this 
happens it seems more appropriate to add conditions for detecting skipping the 
specific test with appropriate bug reference.
   > 
   > If the intention is to fix the problems revealed by the tests then more 
work is needed since the proposed changes cannot land as they are.
   
   The initial motivation was to fix the test failures, which later changed to 
solve the problem revealed in MetaStoreUtils. Upon your comments, I have 
reworked my PR which now solves the problem in MetaStoreUtils and accordingly 
modified TestMetaStoreUtils to validate the tests properly.
   
   @zabetak @wecharyu Please review. Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to