deniskuzZ commented on code in PR #5461:
URL: https://github.com/apache/hive/pull/5461#discussion_r1771397083
##########
ql/src/java/org/apache/hadoop/hive/ql/io/HiveSequenceFileInputFormat.java:
##########
@@ -44,20 +44,20 @@ public HiveSequenceFileInputFormat() {
setMinSplitSize(SequenceFile.SYNC_INTERVAL);
}
- private Set<FileStatus> fileStatuses = null;
+ private ThreadLocal<Set<FileStatus>> fileStatuses = new ThreadLocal<>();
Review Comment:
javadoc :
````
"Each thread holds an implicit reference to its copy of a thread-local
variable as long as the thread is alive and the ThreadLocal instance is
accessible; after a thread goes away, all of its copies of thread-local
instances are subject to garbage collection (unless other references to these
copies exist).
````
If your application uses a thread pool, to prevent memory leaks call the
`ThreadLocal.remove()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
