deniskuzZ commented on code in PR #5436:
URL: https://github.com/apache/hive/pull/5436#discussion_r1776760460


##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -270,7 +275,9 @@ protected void doCommit(TableMetadata base, TableMetadata 
metadata) {
 
         LOG.error("Cannot tell if commit to {}.{} succeeded, attempting to 
reconnect and check.",
             database, tableName, e);
-        commitStatus = checkCommitStatus(newMetadataLocation, metadata);
+        commitStatus =
+                BaseMetastoreOperations.CommitStatus.valueOf(

Review Comment:
   are we using both enums at the same time? since it was deprecated why not 
drop it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to