difin commented on code in PR #5456:
URL: https://github.com/apache/hive/pull/5456#discussion_r1792531402
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorUtil.java:
##########
@@ -337,6 +337,7 @@ private static CompactionResponse
requestCompaction(CompactionInfo ci, String ru
}
compactionRequest.setInitiatorVersion(ci.initiatorVersion);
compactionRequest.setPoolName(ci.poolName);
+ compactionRequest.setOrderByClause(ci.orderByClause);
Review Comment:
Yes, it affects Hive ACID compaction as well because compaction
implementation is common for both ACID and Iceberg tables. But I believe this
change is not dangerous because it just copies an order by clause from
compaction info object to the compaction request which was missing; if the
order by clause is not defined, it will set it as null. Hive ACID compaction
also supports sorting. https://github.com/apache/hive/pull/4077
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
